::icon-press and ::icon-release are not action signals. Pointed out by

        * gtk/gtkentry.c: ::icon-press and ::icon-release are not
        action signals. Pointed out by Murray Cumming

svn path=/trunk/; revision=22501

diff --git a/ChangeLog b/ChangeLog
index 01ff06203737ac4c3340e89c322888f9edb9afc9..d02a32084ff4f474183b42079d15688c9c943974 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-03-10  Matthias Clasen  <mclasen@redhat.com>
+
+       Bug 574622 – GtkEntry: Should we wrap icon-press and icon-release
+       signals?
+
+       * gtk/gtkentry.c: ::icon-press and ::icon-release are not
+       action signals. Pointed out by Murray Cumming
+
 2009-03-04  Michael Hasselmann <michaelh@openismus.com>
 
        * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_contents_changed):

diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index 8ba3e422aa48ac8e721ad45ca0c9e78e77048301..be1a83e65d0c97b834ccf95c3a1b6eab015cbbfb 100644 (file)
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -1455,7 +1455,7 @@ gtk_entry_class_init (GtkEntryClass *class)
    * @icon_pos: The position of the clicked icon
    * @event: the button press event
    *
-   * The ::icon-press signal is emitted when an activatable icon 
+   * The ::icon-press signal is emitted when an activatable icon
    * is clicked.
    *
    * Since: 2.16
@@ -1463,7 +1463,7 @@ gtk_entry_class_init (GtkEntryClass *class)
   signals[ICON_PRESS] =
     g_signal_new (I_("icon-press"),
                   G_TYPE_FROM_CLASS (gobject_class),
-                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                  G_SIGNAL_RUN_LAST,
                   0,
                   NULL, NULL,
                   _gtk_marshal_VOID__ENUM_BOXED,
@@ -1485,7 +1485,7 @@ gtk_entry_class_init (GtkEntryClass *class)
   signals[ICON_RELEASE] =
     g_signal_new (I_("icon-release"),
                   G_TYPE_FROM_CLASS (gobject_class),
-                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                  G_SIGNAL_RUN_LAST,
                   0,
                   NULL, NULL,
                   _gtk_marshal_VOID__ENUM_BOXED,